seccomp: Fix CONFIG tests for Seccomp_filters
authorKenta.Tada@sony.com <Kenta.Tada@sony.com>
Sun, 21 Mar 2021 15:52:19 +0000 (15:52 +0000)
committerKees Cook <keescook@chromium.org>
Wed, 31 Mar 2021 05:33:50 +0000 (22:33 -0700)
Strictly speaking, seccomp filters are only used
when CONFIG_SECCOMP_FILTER.
This patch fixes the condition to enable "Seccomp_filters"
in /proc/$pid/status.

Signed-off-by: Kenta Tada <Kenta.Tada@sony.com>
Fixes: c818c03b661c ("seccomp: Report number of loaded filters in /proc/$pid/status")
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/OSBPR01MB26772D245E2CF4F26B76A989F5669@OSBPR01MB2677.jpnprd01.prod.outlook.com
fs/proc/array.c
init/init_task.c

index bb87e4d..7ec5917 100644 (file)
@@ -342,9 +342,11 @@ static inline void task_seccomp(struct seq_file *m, struct task_struct *p)
        seq_put_decimal_ull(m, "NoNewPrivs:\t", task_no_new_privs(p));
 #ifdef CONFIG_SECCOMP
        seq_put_decimal_ull(m, "\nSeccomp:\t", p->seccomp.mode);
+#ifdef CONFIG_SECCOMP_FILTER
        seq_put_decimal_ull(m, "\nSeccomp_filters:\t",
                            atomic_read(&p->seccomp.filter_count));
 #endif
+#endif
        seq_puts(m, "\nSpeculation_Store_Bypass:\t");
        switch (arch_prctl_spec_ctrl_get(p, PR_SPEC_STORE_BYPASS)) {
        case -EINVAL:
index 3711cda..8b08c2e 100644 (file)
@@ -210,7 +210,7 @@ struct task_struct init_task
 #ifdef CONFIG_SECURITY
        .security       = NULL,
 #endif
-#ifdef CONFIG_SECCOMP
+#ifdef CONFIG_SECCOMP_FILTER
        .seccomp        = { .filter_count = ATOMIC_INIT(0) },
 #endif
 };