wlcore: print the sdio buffer after reading it
authorGuy Mishol <guym@ti.com>
Thu, 26 Jan 2017 15:35:13 +0000 (17:35 +0200)
committerKalle Valo <kvalo@codeaurora.org>
Sat, 28 Jan 2017 07:11:08 +0000 (09:11 +0200)
fix an issue where we printed the sdio buffer before
actually read it.

Signed-off-by: Guy Mishol <guym@ti.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ti/wlcore/sdio.c

index 47fe7f9..287023e 100644 (file)
@@ -81,13 +81,6 @@ static int __must_check wl12xx_sdio_raw_read(struct device *child, int addr,
 
        sdio_claim_host(func);
 
-       if (unlikely(dump)) {
-               printk(KERN_DEBUG "wlcore_sdio: READ from 0x%04x\n", addr);
-               print_hex_dump(KERN_DEBUG, "wlcore_sdio: READ ",
-                               DUMP_PREFIX_OFFSET, 16, 1,
-                               buf, len, false);
-       }
-
        if (unlikely(addr == HW_ACCESS_ELP_CTRL_REG)) {
                ((u8 *)buf)[0] = sdio_f0_readb(func, addr, &ret);
                dev_dbg(child->parent, "sdio read 52 addr 0x%x, byte 0x%02x\n",
@@ -107,6 +100,13 @@ static int __must_check wl12xx_sdio_raw_read(struct device *child, int addr,
        if (WARN_ON(ret))
                dev_err(child->parent, "sdio read failed (%d)\n", ret);
 
+       if (unlikely(dump)) {
+               printk(KERN_DEBUG "wlcore_sdio: READ from 0x%04x\n", addr);
+               print_hex_dump(KERN_DEBUG, "wlcore_sdio: READ ",
+                              DUMP_PREFIX_OFFSET, 16, 1,
+                              buf, len, false);
+       }
+
        return ret;
 }