staging: vt6655: Convert macro vt6655_mac_reg_bits_off to function
authorPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Wed, 13 Jul 2022 05:02:03 +0000 (07:02 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 14 Jul 2022 13:48:38 +0000 (15:48 +0200)
Convert macro vt6655_mac_reg_bits_off to function.
checkpatch.pl does not accept multiline macros.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/422950c8e1349fba2f97b0b95ba13f361cde05d9.1657657918.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6655/mac.c
drivers/staging/vt6655/mac.h

index 076e1bf..aa96842 100644 (file)
@@ -54,6 +54,14 @@ void vt6655_mac_word_reg_bits_on(void __iomem *iobase, const u8 reg_offset, cons
        iowrite16(reg_value | (bit_mask), iobase + reg_offset);
 }
 
+void vt6655_mac_reg_bits_off(void __iomem *iobase, const u8 reg_offset, const u8 bit_mask)
+{
+       unsigned char reg_value;
+
+       reg_value = ioread8(iobase + reg_offset);
+       iowrite8(reg_value & ~(bit_mask), iobase + reg_offset);
+}
+
 /*
  * Description:
  *      Test if all test bits off
index 3b23334..e7b648c 100644 (file)
 
 /*---------------------  Export Macros ------------------------------*/
 
-#define vt6655_mac_reg_bits_off(iobase, reg_offset, bit_mask)                  \
-do {                                                                   \
-       unsigned char reg_value;                                        \
-       reg_value = ioread8(iobase + reg_offset);                       \
-       iowrite8(reg_value & ~(bit_mask), iobase + reg_offset);         \
-} while (0)
-
 #define vt6655_mac_word_reg_bits_off(iobase, reg_offset, bit_mask)     \
 do {                                                                   \
        unsigned short reg_value;                                       \
@@ -654,6 +647,7 @@ do {                                                                        \
 
 void vt6655_mac_reg_bits_on(void __iomem *iobase, const u8 reg_offset, const u8 bit_mask);
 void vt6655_mac_word_reg_bits_on(void __iomem *iobase, const u8 reg_offset, const u16 bit_mask);
+void vt6655_mac_reg_bits_off(void __iomem *iobase, const u8 reg_offset, const u8 bit_mask);
 bool MACbIsRegBitsOff(struct vnt_private *priv, unsigned char byRegOfs,
                      unsigned char byTestBits);