ALSA: emux: Delete two error messages for a failed memory allocation in snd_emux_crea...
authorMarkus Elfring <elfring@users.sourceforge.net>
Wed, 9 Aug 2017 07:30:34 +0000 (09:30 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 10 Aug 2017 15:55:13 +0000 (17:55 +0200)
Omit extra messages for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/synth/emux/emux_seq.c

index fd6cbd4..396c406 100644 (file)
@@ -145,14 +145,12 @@ snd_emux_create_port(struct snd_emux *emu, char *name,
 
        /* Allocate structures for this channel */
        p = kzalloc(sizeof(*p), GFP_KERNEL);
-       if (!p) {
-               snd_printk(KERN_ERR "no memory\n");
+       if (!p)
                return NULL;
-       }
+
        p->chset.channels = kcalloc(max_channels, sizeof(*p->chset.channels),
                                    GFP_KERNEL);
        if (!p->chset.channels) {
-               snd_printk(KERN_ERR "no memory\n");
                kfree(p);
                return NULL;
        }