team: Remove NULL check before dev_{put, hold}
authorYang Li <yang.lee@linux.alibaba.com>
Thu, 27 Jul 2023 00:57:41 +0000 (08:57 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 29 Jul 2023 15:58:00 +0000 (16:58 +0100)
The call netdev_{put, hold} of dev_{put, hold} will check NULL,
so there is no need to check before using dev_{put, hold},
remove it to silence the warning:

./drivers/net/team/team.c:2325:3-10: WARNING: NULL check before dev_{put, hold} functions is not needed.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5991
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/team/team.c

index d3dc225..bc50fc3 100644 (file)
@@ -2321,8 +2321,7 @@ static struct team *team_nl_team_get(struct genl_info *info)
        ifindex = nla_get_u32(info->attrs[TEAM_ATTR_TEAM_IFINDEX]);
        dev = dev_get_by_index(net, ifindex);
        if (!dev || dev->netdev_ops != &team_netdev_ops) {
-               if (dev)
-                       dev_put(dev);
+               dev_put(dev);
                return NULL;
        }