Fix style issues.

TBR=iposva

Review URL: http://codereview.chromium.org/7830

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@543 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

diff --git a/src/api.cc b/src/api.cc
index 5c8075d5399f35278c4cd176e6f0fbc9825afffb..9a662f46c877334fe617d9e00cdb2f7e33b3ea50 100644 (file)
--- a/src/api.cc
+++ b/src/api.cc
@@ -2255,7 +2255,7 @@ Persistent<Context> v8::Context::New(
 
     i::Handle<i::FunctionTemplateInfo> proxy_constructor =
       EnsureConstructor(Utils::OpenHandle(*proxy_template));
-    
+
     // Set the global template to be the prototype template
     // of global proxy template.
     proxy_constructor->set_prototype_template(

diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc
index 92edd1f8cfd453bd33e4924725d9bed3ac4c5d0e..7aba9690518a70cd6a4c0b87cbf85458c2f4bfe4 100644 (file)
--- a/src/bootstrapper.cc
+++ b/src/bootstrapper.cc
@@ -543,7 +543,7 @@ void Genesis::CreateRoots(v8::Handle<v8::ObjectTemplate> global_template,
         if (!proto_template->IsUndefined()) {
           js_global_template =
               Handle<ObjectTemplateInfo>::cast(proto_template);
-        } 
+        }
       }
 
       if (js_global_template.is_null()) {
@@ -1195,7 +1195,7 @@ bool Genesis::ConfigureGlobalObjects(
   Handle<JSObject> js_global(JSObject::cast(global_context()->global()));
 
   if (!global_proxy_template.IsEmpty()) {
-    // Configure the global proxy object. 
+    // Configure the global proxy object.
     Handle<ObjectTemplateInfo> proxy_data =
         v8::Utils::OpenHandle(*global_proxy_template);
     if (!ConfigureApiObject(global_proxy, proxy_data)) return false;
@@ -1204,7 +1204,7 @@ bool Genesis::ConfigureGlobalObjects(
     Handle<FunctionTemplateInfo> proxy_constructor(
         FunctionTemplateInfo::cast(proxy_data->constructor()));
     if (!proxy_constructor->prototype_template()->IsUndefined()) {
-      Handle<ObjectTemplateInfo> inner_data( 
+      Handle<ObjectTemplateInfo> inner_data(
           ObjectTemplateInfo::cast(proxy_constructor->prototype_template()));
       if (!ConfigureApiObject(js_global, inner_data)) return false;
     }
@@ -1214,7 +1214,7 @@ bool Genesis::ConfigureGlobalObjects(
   return true;
 }
 
- 
+
 bool Genesis::ConfigureApiObject(Handle<JSObject> object,
     Handle<ObjectTemplateInfo> object_template) {
   ASSERT(!object_template.is_null());

diff --git a/src/codegen-ia32.cc b/src/codegen-ia32.cc
index 684fa37000c1451e0c39a44e97b8fcec5818e0d2..c90a18b2efd01da9d8a46aae85e70a4a90c051e7 100644 (file)
--- a/src/codegen-ia32.cc
+++ b/src/codegen-ia32.cc
@@ -529,7 +529,6 @@ void CodeGenerator::LoadGlobalReceiver(Register scratch) {
 // that we have the INSIDE_TYPEOF typeof state. => Need to handle global
 // variables w/o reference errors elsewhere.
 void CodeGenerator::LoadTypeofExpression(Expression* x) {
-
   Variable* variable = x->AsVariableProxy()->AsVariable();
   if (variable != NULL && !variable->is_this() && variable->is_global()) {
     // NOTE: This is somewhat nasty. We force the compiler to load

diff --git a/src/macro-assembler-ia32.cc b/src/macro-assembler-ia32.cc
index d0420c3ccca9cfca950ec96dec12b9fc784ed10a..667ff408d25fe9fafa1be171aec7e51925d243ad 100644 (file)
--- a/src/macro-assembler-ia32.cc
+++ b/src/macro-assembler-ia32.cc
@@ -552,8 +552,8 @@ void MacroAssembler::CheckAccessGlobalProxy(Register holder_reg,
   int offset = Context::kHeaderSize + Context::GLOBAL_INDEX * kPointerSize;
   mov(scratch, FieldOperand(scratch, offset));
   mov(scratch, FieldOperand(scratch, GlobalObject::kGlobalContextOffset));
- 
-  // Check the context is a global context. 
+
+  // Check the context is a global context.
   if (FLAG_debug_code) {
     push(scratch);
     // Read the first word and compare to global_context_map.
@@ -571,7 +571,7 @@ void MacroAssembler::CheckAccessGlobalProxy(Register holder_reg,
   // as a temporary register.
   //
   // TODO(119): avoid push(holder_reg)/pop(holder_reg)
-  push(holder_reg); 
+  push(holder_reg);
   // Check that the security token in the calling global object is
   // compatible with the security token in the receiving global
   // object.
@@ -587,14 +587,14 @@ void MacroAssembler::CheckAccessGlobalProxy(Register holder_reg,
     mov(holder_reg, FieldOperand(holder_reg, HeapObject::kMapOffset));
     cmp(holder_reg, Factory::global_context_map());
     Check(equal, "JSGlobalObject::global_context should be a global context.");
-    pop(holder_reg); 
+    pop(holder_reg);
   }
 
   int token_offset = Context::kHeaderSize +
                      Context::SECURITY_TOKEN_INDEX * kPointerSize;
   mov(scratch, FieldOperand(scratch, token_offset));
   cmp(scratch, FieldOperand(holder_reg, token_offset));
-  pop(holder_reg); 
+  pop(holder_reg);
   j(not_equal, miss, not_taken);
 
   bind(&same_contexts);

diff --git a/src/objects-debug.cc b/src/objects-debug.cc
index e68a0be335690b8949e070ff34dd288849f95390..dc5cb602e9519a83816e282733bbf484340bdd74 100644 (file)
--- a/src/objects-debug.cc
+++ b/src/objects-debug.cc
@@ -572,8 +572,8 @@ void JSGlobalProxy::JSGlobalProxyVerify() {
   JSObjectVerify();
   VerifyObjectField(JSGlobalProxy::kContextOffset);
   // Make sure that this object has no properties, elements.
-  CHECK(properties()->length() == 0);
-  CHECK(elements()->length() == 0);
+  CHECK_EQ(0, properties()->length());
+  CHECK_EQ(0, elements()->length());
 }
 
 

diff --git a/src/objects.cc b/src/objects.cc
index b0d33542f0c5e5e2a88b6bf9dd487f528c74da70..72a5e2e1d12a4d4ae057de6ea12c11ed6b47e6e1 100644 (file)
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -1499,7 +1499,7 @@ Object* JSObject::SetProperty(LookupResult* result,
     Object* proto = GetPrototype();
     if (proto->IsNull()) return value;
     ASSERT(proto->IsJSGlobalObject());
-    return JSObject::cast(proto)->SetProperty(result, name, value, attributes);    
+    return JSObject::cast(proto)->SetProperty(result, name, value, attributes);
   }
 
   if (result->IsNotFound() || !result->IsProperty()) {

diff --git a/src/objects.h b/src/objects.h
index 3ecf37c2a4844707b25cee98f70d5c3b427ddb4c..b59dfc030f89db201775ecda15c55f431ce6b0be 100644 (file)
--- a/src/objects.h
+++ b/src/objects.h
@@ -48,7 +48,7 @@
 //         - GlobalObject
 //           - JSGlobalObject
 //           - JSBuiltinsObject
-//         _ JSGlobalProxy 
+//         _ JSGlobalProxy
 //         - JSValue
 //         - Script
 //       - Array

diff --git a/src/top.cc b/src/top.cc
index 19361a3515f1a50363f4f14f014b78eeb469a936..6dbb52272e40ad9e0d6daee28309d0b9e04ce4b7 100644 (file)
--- a/src/top.cc
+++ b/src/top.cc
@@ -464,7 +464,7 @@ void Top::ReportFailedAccessCheck(JSObject* receiver, v8::AccessType type) {
 }
 
 
-enum MayAccessDecision{
+enum MayAccessDecision {
   YES, NO, UNKNOWN
 };
 
@@ -481,7 +481,7 @@ static MayAccessDecision MayAccessPreCheck(JSObject* receiver,
     // Get the global context of current top context.
     // avoid using Top::global_context() because it uses Handle.
     Context* global_context = Top::context()->global()->global_context();
-    if (receiver_context == global_context) return YES; 
+    if (receiver_context == global_context) return YES;
 
     if (Context::cast(receiver_context)->security_token() ==
         global_context->security_token())

diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index 1fb2b81dcfaaa6248a098abd7e21d4e248a8f626..55a844f181abf09699a7736c648372abe841fa8a 100644 (file)
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -3273,7 +3273,7 @@ TEST(ContextDetachGlobal) {
   // Check that env3 is not accessible from env1
   {
     Local<Value> r = global3->Get(v8_str("prop2"));
-    CHECK(r->IsUndefined());    
+    CHECK(r->IsUndefined());
   }
 
   env2.Dispose();