selftests/bpf/xdp_redirect_multi: Give tcpdump a chance to terminate cleanly
authorHangbin Liu <liuhangbin@gmail.com>
Wed, 27 Oct 2021 03:35:52 +0000 (11:35 +0800)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 5 Nov 2021 15:38:26 +0000 (16:38 +0100)
No need to kill tcpdump with -9.

Fixes: d23292476297 ("selftests/bpf: Add xdp_redirect_multi test")
Suggested-by: Jiri Benc <jbenc@redhat.com>
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20211027033553.962413-4-liuhangbin@gmail.com
tools/testing/selftests/bpf/test_xdp_redirect_multi.sh

index e14dc41..d4cdb76 100755 (executable)
@@ -106,7 +106,7 @@ do_egress_tests()
        sleep 0.5
        ip netns exec ns1 ping 192.0.2.254 -i 0.1 -c 4 &> /dev/null
        sleep 0.5
-       pkill -9 tcpdump
+       pkill tcpdump
 
        # mac check
        grep -q "${veth_mac[2]} > ff:ff:ff:ff:ff:ff" ${LOG_DIR}/mac_ns1-2_${mode}.log && \
@@ -133,7 +133,7 @@ do_ping_tests()
        # IPv6 test
        ip netns exec ns1 ping6 2001:db8::2 -i 0.1 -c 2 &> /dev/null
        sleep 0.5
-       pkill -9 tcpdump
+       pkill tcpdump
 
        # All netns should receive the redirect arp requests
        [ $(grep -cF "who-has 192.0.2.254" ${LOG_DIR}/ns1-1_${mode}.log) -eq 4 ] && \