test: use tmp directory in chdir test
authorSakthipriyan Vairamani <thechargingvolcano@gmail.com>
Fri, 28 Aug 2015 01:50:39 +0000 (07:20 +0530)
committerJeremiah Senkpiel <fishrock123@rocketmail.com>
Thu, 17 Sep 2015 01:03:52 +0000 (21:03 -0400)
This patch

 - makes chdir test to use the tmp directory
 - moves the test to parallel
 - renames the file to test-process-chdir as chdir is in process module

PR-URL: https://github.com/nodejs/node/pull/2589
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
test/parallel/test-process-chdir.js [new file with mode: 0644]
test/sequential/test-chdir.js [deleted file]

diff --git a/test/parallel/test-process-chdir.js b/test/parallel/test-process-chdir.js
new file mode 100644 (file)
index 0000000..ed8bf83
--- /dev/null
@@ -0,0 +1,28 @@
+'use strict';
+
+const common = require('../common');
+const assert = require('assert');
+const fs = require('fs');
+const path = require('path');
+
+assert.notStrictEqual(process.cwd(), __dirname);
+process.chdir(__dirname);
+assert.strictEqual(process.cwd(), __dirname);
+
+const dir = path.resolve(common.tmpDir,
+    'weird \uc3a4\uc3ab\uc3af characters \u00e1\u00e2\u00e3');
+
+// Make sure that the tmp directory is clean
+common.refreshTmpDir();
+
+fs.mkdirSync(dir);
+process.chdir(dir);
+assert.strictEqual(process.cwd(), dir);
+
+process.chdir('..');
+assert.strictEqual(process.cwd(), path.resolve(common.tmpDir));
+
+assert.throws(function() { process.chdir({}); }, TypeError, 'Bad argument.');
+assert.throws(function() { process.chdir(); }, TypeError, 'Bad argument.');
+assert.throws(function() { process.chdir('x', 'y'); },
+              TypeError, 'Bad argument.');
diff --git a/test/sequential/test-chdir.js b/test/sequential/test-chdir.js
deleted file mode 100644 (file)
index bab421e..0000000
+++ /dev/null
@@ -1,38 +0,0 @@
-'use strict';
-var common = require('../common');
-var assert = require('assert');
-var fs = require('fs');
-var path = require('path');
-
-assert.equal(true, process.cwd() !== __dirname);
-
-process.chdir(__dirname);
-assert.equal(true, process.cwd() === __dirname);
-
-var dir = path.resolve(common.fixturesDir,
-    'weird \uc3a4\uc3ab\uc3af characters \u00e1\u00e2\u00e3');
-
-try {
-  fs.mkdirSync(dir);
-} catch (e) {
-  if (e.code !== 'EEXIST') {
-    cleanup();
-    throw e;
-  }
-}
-
-process.chdir(dir);
-assert(process.cwd() == dir);
-
-process.chdir('..');
-assert(process.cwd() == path.resolve(common.fixturesDir));
-cleanup();
-
-assert.throws(function() { process.chdir({}); }, TypeError, 'Bad argument.');
-assert.throws(function() { process.chdir(); }, TypeError, 'Bad argument.');
-assert.throws(function() { process.chdir('x', 'y'); },
-              TypeError, 'Bad argument.');
-
-function cleanup() {
-  fs.rmdirSync(dir);
-}