Remove coreclr shutdown from coreclr_t destructor. (dotnet/core-setup#5612)
authorAaron Robinson <arobins@microsoft.com>
Fri, 29 Mar 2019 18:44:41 +0000 (11:44 -0700)
committerGitHub <noreply@github.com>
Fri, 29 Mar 2019 18:44:41 +0000 (11:44 -0700)
Commit migrated from https://github.com/dotnet/core-setup/commit/d18247239a28e4ec353f92bedf2dde153a8068ea

src/installer/corehost/cli/coreclr.cpp
src/installer/corehost/cli/coreclr.h

index a942761..9392711 100644 (file)
@@ -74,14 +74,6 @@ namespace
 
         return true;
     }
-    
-    void coreclr_unload()
-    {
-        assert(g_coreclr != nullptr && coreclr_initialize != nullptr);
-
-        // [TODO] Unloading coreclr is not presently supported
-        // pal::unload_library(g_coreclr);
-    }
 }
 
 pal::hresult_t coreclr_t::create(
@@ -126,12 +118,6 @@ coreclr_t::coreclr_t(host_handle_t host_handle, domain_id_t domain_id)
 {
 }
 
-coreclr_t::~coreclr_t()
-{
-    (void)shutdown(nullptr);
-    coreclr_unload();
-}
-
 pal::hresult_t coreclr_t::execute_assembly(
     int argc,
     const char** argv,
index 6213660..85fcca7 100644 (file)
@@ -29,7 +29,7 @@ public:
     using domain_id_t = std::uint32_t;
 
     coreclr_t(host_handle_t host_handle, domain_id_t domain_id);
-    ~coreclr_t();
+    ~coreclr_t() = default;
 
     pal::hresult_t execute_assembly(
         int argc,