[M68k] Fix extract-section.py under Python 3
authorRicky Taylor <rickytaylor26@gmail.com>
Sun, 14 Mar 2021 18:36:57 +0000 (11:36 -0700)
committerMin-Yih Hsu <minyihh@uci.edu>
Sun, 14 Mar 2021 18:36:57 +0000 (11:36 -0700)
read_raw_stdin() was opening a file in binary mode, but Popen
was being told to use text mode (universal_newlines). This is
benign on Python 2 but an error on Python 3.

Differential Revision: https://reviews.llvm.org/D98428

llvm/utils/extract-section.py

index ab47551..ca19b0e 100755 (executable)
@@ -33,8 +33,7 @@ def get_raw_section_dump(readobj_path, section_name, input_file):
     import subprocess
     cmd = [readobj_path, '-elf-output-style=GNU', '--hex-dump={}'.format(section_name),
             input_file]
-    proc = subprocess.Popen(cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE,
-            universal_newlines=True)
+    proc = subprocess.Popen(cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE)
 
     if input_file == '-':
         # From stdin