Add IgnoreForCI property to certain no-op test suites (#90238)
authorAlexander Köplinger <alex.koeplinger@outlook.com>
Wed, 9 Aug 2023 18:46:45 +0000 (20:46 +0200)
committerGitHub <noreply@github.com>
Wed, 9 Aug 2023 18:46:45 +0000 (20:46 +0200)
A couple projects have all tests disabled, it makes no sense to send them to Helix to run 0 tests.

src/libraries/Microsoft.Extensions.Caching.Memory/tests/AssemblyAttributes.cs
src/libraries/Microsoft.Extensions.Caching.Memory/tests/Microsoft.Extensions.Caching.Memory.Tests.csproj
src/libraries/Microsoft.Extensions.Hosting/tests/FunctionalTests/Microsoft.Extensions.Hosting.Functional.Tests.csproj
src/libraries/Microsoft.Extensions.Hosting/tests/FunctionalTests/Properties/AssemblyInfo.cs
src/libraries/Microsoft.Extensions.Hosting/tests/FunctionalTests/ShutdownTests.cs
src/libraries/System.ComponentModel.Composition/tests/AssemblyInfo.cs
src/libraries/System.ComponentModel.Composition/tests/System.ComponentModel.Composition.Tests.csproj

index 167b803..2a244c8 100644 (file)
@@ -3,4 +3,4 @@
 
 using Xunit;
 
-[assembly: ActiveIssue("https://github.com/dotnet/runtime/issues/35970", TestRuntimes.Mono)]
+[assembly: ActiveIssue("https://github.com/dotnet/runtime/issues/35970", TestRuntimes.Mono)] // Note: remove IgnoreForCI from .csproj when reenabling
index 429cde4..1d602a7 100644 (file)
@@ -3,6 +3,8 @@
   <PropertyGroup>
     <TargetFrameworks>$(NetCoreAppCurrent);$(NetFrameworkMinimum)</TargetFrameworks>
     <EnableDefaultItems>true</EnableDefaultItems>
+    <!-- ActiveIssue in AssemblyInfo.cs for Mono -->
+    <IgnoreForCI Condition="'$(RuntimeFlavor)' == 'Mono'">true</IgnoreForCI>
   </PropertyGroup>
 
   <ItemGroup>
index 11a32ba..83bb46b 100644 (file)
@@ -3,6 +3,8 @@
   <PropertyGroup>
     <TargetFrameworks>$(NetCoreAppCurrent);$(NetFrameworkMinimum)</TargetFrameworks>
     <EnableDefaultItems>true</EnableDefaultItems>
+    <!-- ActiveIssue in AssemblyInfo.cs -->
+    <IgnoreForCI>true</IgnoreForCI>
   </PropertyGroup>
 
   <ItemGroup>
index cc0c223..3e1a24a 100644 (file)
@@ -4,3 +4,4 @@
 using Xunit;
 
 [assembly: CollectionBehavior(CollectionBehavior.CollectionPerAssembly)]
+[assembly: ActiveIssue("https://github.com/dotnet/runtime/issues/34090")] // Note: remove IgnoreForCI from .csproj when reenabling
index 96ebf63..e55a29d 100644 (file)
@@ -29,7 +29,6 @@ namespace Microsoft.AspNetCore.Hosting.FunctionalTests
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/34090")]
         [PlatformSpecific(TestPlatforms.Linux)]
         public async Task ShutdownTestRun()
         {
@@ -37,7 +36,6 @@ namespace Microsoft.AspNetCore.Hosting.FunctionalTests
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/34090")]
         [PlatformSpecific(TestPlatforms.Linux)]
         public async Task ShutdownTestWaitForShutdown()
         {
index b0523cb..243d549 100644 (file)
@@ -3,4 +3,4 @@
 
 using Xunit;
 
-[assembly: ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] // flaky tests
+[assembly: ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] // flaky tests. Note: remove IgnoreForCI from .csproj when reenabling
index a5f48c6..49cb241 100644 (file)
@@ -2,6 +2,8 @@
   <PropertyGroup>
     <IncludeRemoteExecutor>true</IncludeRemoteExecutor>
     <TargetFramework>$(NetCoreAppCurrent)</TargetFramework>
+    <!-- ActiveIssue in AssemblyInfo.cs for Mono -->
+    <IgnoreForCI Condition="'$(RuntimeFlavor)' == 'Mono'">true</IgnoreForCI>
   </PropertyGroup>
   <ItemGroup>
     <Compile Include="$(CommonTestPath)System\IO\TempDirectory.cs"