ice: Introduce local var for readability
authorTony Nguyen <anthony.l.nguyen@intel.com>
Thu, 15 Dec 2022 21:36:51 +0000 (13:36 -0800)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Thu, 19 Jan 2023 16:18:03 +0000 (08:18 -0800)
Based on previous feedback[1], introduce a local var to make things more
readable.

[1] https://lore.kernel.org/netdev/20220315203218.607f612b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com/

Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
drivers/net/ethernet/intel/ice/ice_main.c

index c6d57f3..cb870da 100644 (file)
@@ -5046,8 +5046,11 @@ static void ice_setup_mc_magic_wake(struct ice_pf *pf)
 static void ice_remove(struct pci_dev *pdev)
 {
        struct ice_pf *pf = pci_get_drvdata(pdev);
+       struct ice_hw *hw;
        int i;
 
+       hw = &pf->hw;
+
        ice_devlink_unregister(pf);
        for (i = 0; i < ICE_MAX_RESET_WAIT; i++) {
                if (!ice_is_reset_in_progress(pf->state))
@@ -5080,7 +5083,7 @@ static void ice_remove(struct pci_dev *pdev)
                ice_remove_arfs(pf);
        ice_setup_mc_magic_wake(pf);
        ice_vsi_release_all(pf);
-       mutex_destroy(&(&pf->hw)->fdir_fltr_lock);
+       mutex_destroy(&hw->fdir_fltr_lock);
        ice_set_wake(pf);
        ice_free_irq_msix_misc(pf);
        ice_for_each_vsi(pf, i) {
@@ -5092,13 +5095,13 @@ static void ice_remove(struct pci_dev *pdev)
        pf->vsi_stats = NULL;
        ice_deinit_pf(pf);
        ice_devlink_destroy_regions(pf);
-       ice_deinit_hw(&pf->hw);
+       ice_deinit_hw(hw);
 
        /* Issue a PFR as part of the prescribed driver unload flow.  Do not
         * do it via ice_schedule_reset() since there is no need to rebuild
         * and the service task is already stopped.
         */
-       ice_reset(&pf->hw, ICE_RESET_PFR);
+       ice_reset(hw, ICE_RESET_PFR);
        pci_wait_for_pending_transaction(pdev);
        ice_clear_interrupt_scheme(pf);
        pci_disable_pcie_error_reporting(pdev);