gdb/

	Fix static analysis issue found by cppcheck.
	* microblaze-tdep.c (microblaze_extract_return_value): Fix
	uninitialized BUF for size 2.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e312919..6fcb90f 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2012-02-28  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+       Fix static analysis issue found by cppcheck.
+       * microblaze-tdep.c (microblaze_extract_return_value): Fix
+       uninitialized BUF for size 2.
+
 2012-02-27  Chris Dearman  <chris@mips.com>
             Nathan Froyd  <froydnj@codesourcery.com>
             Maciej W. Rozycki  <macro@codesourcery.com>

diff --git a/gdb/microblaze-tdep.c b/gdb/microblaze-tdep.c
index ca6d129..6aea41e 100644 (file)
--- a/gdb/microblaze-tdep.c
+++ b/gdb/microblaze-tdep.c
@@ -562,6 +562,7 @@ microblaze_extract_return_value (struct type *type, struct regcache *regcache,
        memcpy(valbuf, buf + MICROBLAZE_REGISTER_SIZE - 1, 1);
        return;
       case 2:  /* return last 2 bytes in register.  */
+       regcache_cooked_read (regcache, MICROBLAZE_RETVAL_REGNUM, buf);
        memcpy(valbuf, buf + MICROBLAZE_REGISTER_SIZE - 2, 2);
        return;
       case 4:  /* for sizes 4 or 8, copy the required length.  */