<rdar://problem/12831670>
authorJason Molenda <jmolenda@apple.com>
Fri, 7 Dec 2012 03:38:23 +0000 (03:38 +0000)
committerJason Molenda <jmolenda@apple.com>
Fri, 7 Dec 2012 03:38:23 +0000 (03:38 +0000)
When using the same-device optimization for shared cache libraries, if
we have an invalid load address for __LINKEDIT, don't try to read
anything out of lldb's own address space.  Reading it out of the remote
address space will fail gracefully if we have bad addresses but reading
it out of lldb's own address space will result in a crash.

llvm-svn: 169582

lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp

index 4d6d007..936c1e9 100644 (file)
@@ -1326,7 +1326,7 @@ ObjectFileMachO::ParseSymtab (bool minimize)
                     // data across can slow down debug launch times, so we optimize this by
                     // reading the memory for the __LINKEDIT section from this process.
                     PlatformSP platform_sp (target.GetPlatform());
-                    if (platform_sp && platform_sp->IsHost())
+                    if (platform_sp && platform_sp->IsHost() && linkedit_load_addr != LLDB_INVALID_ADDRESS)
                     {
                         data_was_read = true;
                         nlist_data.SetData((void *)symoff_addr, nlist_data_byte_size, eByteOrderLittle);