egl: drop EGL driver `name`
authorEric Engestrom <eric.engestrom@imgtec.com>
Wed, 18 Oct 2017 15:32:33 +0000 (16:32 +0100)
committerEric Engestrom <eric.engestrom@imgtec.com>
Wed, 18 Oct 2017 16:25:41 +0000 (17:25 +0100)
The "DRI2" name was reported as confusing when printing EGL infos (one
user reported thinking DRI3 was not working on his X server), and the
only alternative is Haiku, which can only be used on a Haiku machine.

The name therefore doesn't add any information that the user wouldn't
know already, so let's just drop it.

Cc: Kai Wasserbäch <kai@dev.carbon-project.org>
Suggested-by: Emil Velikov <emil.l.velikov@gmail.com>
Related-to: b174a1ae720cb404738c ("egl: Simplify the "driver" interface")
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
src/egl/drivers/dri2/egl_dri2.c
src/egl/drivers/haiku/egl_haiku.cpp
src/egl/main/eglapi.c
src/egl/main/egldriver.c
src/egl/main/egldriver.h

index 0750dc1..f9fc71e 100644 (file)
@@ -3244,6 +3244,4 @@ _eglInitDriver(_EGLDriver *dri2_drv)
    dri2_drv->API.GLInteropQueryDeviceInfo = dri2_interop_query_device_info;
    dri2_drv->API.GLInteropExportObject = dri2_interop_export_object;
    dri2_drv->API.DupNativeFenceFDANDROID = dri2_dup_native_fence_fd;
-
-   dri2_drv->Name = "DRI2";
 }
index 590e43f..0b56653 100644 (file)
@@ -325,7 +325,5 @@ _eglInitDriver(_EGLDriver *driver)
 
        driver->API.SwapBuffers = haiku_swap_buffers;
 
-       driver->Name = "Haiku";
-
        TRACE("API Calls defined\n");
 }
index 38fc931..36d6968 100644 (file)
@@ -615,8 +615,7 @@ eglInitialize(EGLDisplay dpy, EGLint *major, EGLint *minor)
       _eglCreateExtensionsString(disp);
       _eglCreateAPIsString(disp);
       snprintf(disp->VersionString, sizeof(disp->VersionString),
-               "%d.%d (%s)", disp->Version / 10, disp->Version % 10,
-               disp->Driver->Name);
+               "%d.%d", disp->Version / 10, disp->Version % 10);
    }
 
    /* Update applications version of major and minor if not NULL */
index 003f74e..33f8f57 100644 (file)
@@ -95,8 +95,6 @@ _eglMatchDriver(_EGLDisplay *dpy)
    }
 
    if (best_drv) {
-      _eglLog(_EGL_DEBUG, "the best driver is %s",
-            best_drv->Name);
       dpy->Driver = best_drv;
       dpy->Initialized = EGL_TRUE;
    }
index ba12a06..5695fc0 100644 (file)
@@ -75,8 +75,6 @@ extern "C" {
  */
 struct _egl_driver
 {
-   const char *Name;  /**< name of this driver */
-
    _EGLAPI API;  /**< EGL API dispatch table */
 };