dns_resolver: Null-terminate the right string
authorBen Hutchings <ben@decadent.org.uk>
Sun, 20 Jul 2014 23:06:48 +0000 (00:06 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 21 Jul 2014 05:33:32 +0000 (22:33 -0700)
*_result[len] is parsed as *(_result[len]) which is not at all what we
want to touch here.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Fixes: 84a7c0b1db1c ("dns_resolver: assure that dns_query() result is null-terminated")
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dns_resolver/dns_query.c

index 9acec61..dd8696a 100644 (file)
@@ -150,7 +150,7 @@ int dns_query(const char *type, const char *name, size_t namelen,
                goto put;
 
        memcpy(*_result, upayload->data, len);
-       *_result[len] = '\0';
+       (*_result)[len] = '\0';
 
        if (_expiry)
                *_expiry = rkey->expiry;