ALSA: pcsp: Fix the order of input device unregistration
authorTakashi Iwai <tiwai@suse.de>
Thu, 14 Nov 2013 14:45:12 +0000 (15:45 +0100)
committerTakashi Iwai <tiwai@suse.de>
Thu, 14 Nov 2013 14:50:10 +0000 (15:50 +0100)
The current code may access to the already freed object.  The input
device must be accessed and unregistered before freeing the top level
sound object.

Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/drivers/pcsp/pcsp.c

index f664bae..328bd29 100644 (file)
@@ -188,8 +188,8 @@ static int pcsp_probe(struct platform_device *dev)
 static int pcsp_remove(struct platform_device *dev)
 {
        struct snd_pcsp *chip = platform_get_drvdata(dev);
-       alsa_card_pcsp_exit(chip);
        pcspkr_input_remove(chip->input_dev);
+       alsa_card_pcsp_exit(chip);
        return 0;
 }