8139too: Fix the lack of pci_disable_device
authorJia-Ju Bai <baijiaju1990@163.com>
Mon, 22 Dec 2014 00:28:52 +0000 (08:28 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 22 Dec 2014 21:31:58 +0000 (16:31 -0500)
For linux-3.18.0
When pci_request_regions is failed in rtl8139_init_board, pci_disable_device
is not called to disable the device which are enabled by pci_enable_device,
because of disable_dev_on_err is not assigned 1.
This patch fix this problem.

Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/realtek/8139too.c

index 6d0b9df..d4b0a29 100644 (file)
@@ -787,10 +787,10 @@ static struct net_device *rtl8139_init_board(struct pci_dev *pdev)
        if (rc)
                goto err_out;
 
+       disable_dev_on_err = 1;
        rc = pci_request_regions (pdev, DRV_NAME);
        if (rc)
                goto err_out;
-       disable_dev_on_err = 1;
 
        pci_set_master (pdev);