[ADT] Remove 0-width Asserts in APInt.getZExtValue
authorSchuyler Eldridge <schuyler.eldridge@sifive.com>
Tue, 30 Nov 2021 05:47:08 +0000 (00:47 -0500)
committerSchuyler Eldridge <schuyler.eldridge@sifive.com>
Tue, 30 Nov 2021 22:03:12 +0000 (17:03 -0500)
Remove assertion that disallows getting a zero-extended value from a
zero-width APInt.  This check is too restrictive and makes it difficult
to use APInt to model zero-width things, e.g., zero-width wires in the
CIRCT project.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Reviewed By: lattner, darthscsi, nikic

Differential Revision: https://reviews.llvm.org/D114768

llvm/include/llvm/ADT/APInt.h
llvm/unittests/ADT/APIntTest.cpp

index 595cd94..c266050 100644 (file)
@@ -1458,10 +1458,8 @@ public:
   /// uint64_t. The bitwidth must be <= 64 or the value must fit within a
   /// uint64_t. Otherwise an assertion will result.
   uint64_t getZExtValue() const {
-    if (isSingleWord()) {
-      assert(BitWidth && "zero width values not allowed");
+    if (isSingleWord())
       return U.VAL;
-    }
     assert(getActiveBits() <= 64 && "Too many bits for uint64_t");
     return U.pVal[0];
   }
index 8a73163..95cb213 100644 (file)
@@ -3054,6 +3054,9 @@ TEST(APIntTest, ZeroWidth) {
   EXPECT_EQ(0U, APInt(4, 3).trunc(0).getBitWidth());
   EXPECT_TRUE(ZW.isAllOnes());
 
+  // Zero extension.
+  EXPECT_EQ(0U, ZW.getZExtValue());
+
   SmallString<42> STR;
   ZW.toStringUnsigned(STR);
   EXPECT_EQ("0", STR);