drm/mediatek: Fix uninitialized symbol
authorNancy.Lin <nancy.lin@mediatek.com>
Thu, 3 Aug 2023 09:48:43 +0000 (17:48 +0800)
committerChun-Kuang Hu <chunkuang.hu@kernel.org>
Mon, 7 Aug 2023 23:26:07 +0000 (23:26 +0000)
Fix Smatch static checker warning
  -Fix uninitialized symbol comp_pdev in mtk_ddp_comp_init.

Fixes: 0d9eee9118b7 ("drm/mediatek: Add drm ovl_adaptor sub driver for MT8195")
Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com>
Link: https://patchwork.kernel.org/project/dri-devel/patch/20230803094843.4439-1-nancy.lin@mediatek.com/
Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c

index f114da4..771f4e1 100644 (file)
@@ -563,14 +563,15 @@ int mtk_ddp_comp_init(struct device_node *node, struct mtk_ddp_comp *comp,
        /* Not all drm components have a DTS device node, such as ovl_adaptor,
         * which is the drm bring up sub driver
         */
-       if (node) {
-               comp_pdev = of_find_device_by_node(node);
-               if (!comp_pdev) {
-                       DRM_INFO("Waiting for device %s\n", node->full_name);
-                       return -EPROBE_DEFER;
-               }
-               comp->dev = &comp_pdev->dev;
+       if (!node)
+               return 0;
+
+       comp_pdev = of_find_device_by_node(node);
+       if (!comp_pdev) {
+               DRM_INFO("Waiting for device %s\n", node->full_name);
+               return -EPROBE_DEFER;
        }
+       comp->dev = &comp_pdev->dev;
 
        if (type == MTK_DISP_AAL ||
            type == MTK_DISP_BLS ||
@@ -580,7 +581,6 @@ int mtk_ddp_comp_init(struct device_node *node, struct mtk_ddp_comp *comp,
            type == MTK_DISP_MERGE ||
            type == MTK_DISP_OVL ||
            type == MTK_DISP_OVL_2L ||
-           type == MTK_DISP_OVL_ADAPTOR ||
            type == MTK_DISP_PWM ||
            type == MTK_DISP_RDMA ||
            type == MTK_DPI ||