scsi: tcmu: use lio core se_device configuration helper
authorMike Christie <mchristi@redhat.com>
Mon, 23 Jul 2018 19:07:46 +0000 (14:07 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 31 Jul 2018 03:17:53 +0000 (23:17 -0400)
Use the lio core helper to check if the device is configured.

Signed-off-by: Mike Christie <mchristi@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/target_core_user.c

index b010ed7..bc8121f 100644 (file)
@@ -1908,11 +1908,6 @@ err_bitmap_alloc:
        return ret;
 }
 
-static bool tcmu_dev_configured(struct tcmu_dev *udev)
-{
-       return udev->uio_info.uio_dev ? true : false;
-}
-
 static void tcmu_free_device(struct se_device *dev)
 {
        struct tcmu_dev *udev = TCMU_DEV(dev);
@@ -2305,7 +2300,7 @@ static ssize_t tcmu_dev_config_store(struct config_item *item, const char *page,
                return -EINVAL;
 
        /* Check if device has been configured before */
-       if (tcmu_dev_configured(udev)) {
+       if (target_dev_configured(&udev->se_dev)) {
                ret = tcmu_send_dev_config_event(udev, page);
                if (ret) {
                        pr_err("Unable to reconfigure device\n");
@@ -2367,7 +2362,7 @@ static ssize_t tcmu_dev_size_store(struct config_item *item, const char *page,
                return ret;
 
        /* Check if device has been configured before */
-       if (tcmu_dev_configured(udev)) {
+       if (target_dev_configured(&udev->se_dev)) {
                ret = tcmu_send_dev_size_event(udev, val);
                if (ret) {
                        pr_err("Unable to reconfigure device\n");
@@ -2449,7 +2444,7 @@ static ssize_t tcmu_emulate_write_cache_store(struct config_item *item,
                return ret;
 
        /* Check if device has been configured before */
-       if (tcmu_dev_configured(udev)) {
+       if (target_dev_configured(&udev->se_dev)) {
                ret = tcmu_send_emulate_write_cache(udev, val);
                if (ret) {
                        pr_err("Unable to reconfigure device\n");