vdpa/mlx5: Restore cur_num_vqs in case of failure in change_num_qps()
authorEli Cohen <elic@nvidia.com>
Wed, 5 Jan 2022 11:46:41 +0000 (13:46 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jan 2022 10:05:36 +0000 (11:05 +0100)
commit 37e07e705888e4c3502f204e9c6785c9c2d6d86a upstream.

Restore ndev->cur_num_vqs to the original value in case change_num_qps()
fails.

Fixes: 52893733f2c5 ("vdpa/mlx5: Add multiqueue support")
Reviewed-by: Si-Wei Liu<si-wei.liu@oracle.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Eli Cohen <elic@nvidia.com>
Link: https://lore.kernel.org/r/20220105114646.577224-10-elic@nvidia.com
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/vdpa/mlx5/net/mlx5_vnet.c

index a8a67fb..1afbda2 100644 (file)
@@ -1510,9 +1510,11 @@ static int change_num_qps(struct mlx5_vdpa_dev *mvdev, int newqps)
        return 0;
 
 clean_added:
-       for (--i; i >= cur_qps; --i)
+       for (--i; i >= 2 * cur_qps; --i)
                teardown_vq(ndev, &ndev->vqs[i]);
 
+       ndev->cur_num_vqs = 2 * cur_qps;
+
        return err;
 }