Remove unnecessary assignments from CSSParser::parseLinearGradient().

https://bugs.webkit.org/show_bug.cgi?id=83661

Reviewed by Kentaro Hara.

No new tests / code cleanup only.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseLinearGradient):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index 6af0138..d010506 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2012-04-11  Luke Macpherson  <macpherson@chromium.org>
+
+        Remove unnecessary assignments from CSSParser::parseLinearGradient().
+        https://bugs.webkit.org/show_bug.cgi?id=83661
+
+        Reviewed by Kentaro Hara.
+
+        No new tests / code cleanup only.
+
+        * css/CSSParser.cpp:
+        (WebCore::CSSParser::parseLinearGradient):
+
 2012-04-11  Stephen Chenney  <schenney@chromium.org>
 
         Shadow tree TreeScope data is not removed by ContainerNode::removeAllChildren

diff --git a/Source/WebCore/css/CSSParser.cpp b/Source/WebCore/css/CSSParser.cpp
index 6a600ef..84881d3 100644 (file)
--- a/Source/WebCore/css/CSSParser.cpp
+++ b/Source/WebCore/css/CSSParser.cpp
@@ -6389,7 +6389,7 @@ bool CSSParser::parseLinearGradient(CSSParserValueList* valueList, RefPtr<CSSVal
     if (validUnit(a, FAngle, CSSStrictMode)) {
         result->setAngle(createPrimitiveNumericValue(a));
 
-        a = args->next();
+        args->next();
         expectComma = true;
     } else {
         // Look one or two optional keywords that indicate a side or corner.
@@ -6403,8 +6403,7 @@ bool CSSParser::parseLinearGradient(CSSParserValueList* valueList, RefPtr<CSSVal
             else
                 startY = location;
 
-            a = args->next();
-            if (a) {
+            if ((a = args->next())) {
                 if ((location = valueFromSideKeyword(a, isHorizontal))) {
                     if (isHorizontal) {
                         if (startX)
@@ -6416,7 +6415,7 @@ bool CSSParser::parseLinearGradient(CSSParserValueList* valueList, RefPtr<CSSVal
                         startY = location;
                     }
 
-                    a = args->next();
+                    args->next();
                 }
             }