rpmsg: virtio_rpmsg_bus: use dev_warn_ratelimited for msg with no recipient
authorAlexandru Ardelean <ardeleanalex@gmail.com>
Tue, 28 Sep 2021 13:29:02 +0000 (16:29 +0300)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Sat, 9 Oct 2021 03:29:27 +0000 (22:29 -0500)
Even though it may be user-space's fault for this error (some application
terminated or crashed without cleaning up it's endpoint), the rpmsg
communication should not overflow the syslog with too many messages.

A dev_warn_ratelimited() seems like a good alternative in case this can
occur.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20210928132902.1594277-1-aardelean@deviqon.com
drivers/rpmsg/virtio_rpmsg_bus.c

index a0634ef..5da622e 100644 (file)
@@ -748,7 +748,7 @@ static int rpmsg_recv_single(struct virtproc_info *vrp, struct device *dev,
                /* farewell, ept, we don't need you anymore */
                kref_put(&ept->refcount, __ept_release);
        } else
-               dev_warn(dev, "msg received with no recipient\n");
+               dev_warn_ratelimited(dev, "msg received with no recipient\n");
 
        /* publish the real size of the buffer */
        rpmsg_sg_init(&sg, msg, vrp->buf_size);