media: mediatek: vcodec: fix unreasonable parameter definition and style
authorYunfei Dong <yunfei.dong@mediatek.com>
Sat, 29 Jul 2023 02:55:12 +0000 (10:55 +0800)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Thu, 10 Aug 2023 05:58:33 +0000 (07:58 +0200)
Fix unreasonable coding style.
Fix unreasonable parameter definition.

Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.h
drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.h

index 533d8d9..4122e37 100644 (file)
@@ -19,7 +19,7 @@
 #define IS_VDEC_INNER_RACING(capability) ((capability) & MTK_VCODEC_INNER_RACING)
 
 /*
- * struct mtk_vdec_format_types - Structure used to get supported
+ * enum mtk_vdec_format_types - Structure used to get supported
  *               format types according to decoder capability
  */
 enum mtk_vdec_format_types {
@@ -258,7 +258,7 @@ struct mtk_vcodec_dec_dev {
        struct regmap *vdecsys_regmap;
 
        struct mtk_vcodec_fw *fw_handler;
-       unsigned long id_counter;
+       u64 id_counter;
 
        /* decoder hardware mutex lock */
        struct mutex dec_mutex[MTK_VDEC_HW_MAX];
index 2f6d016..5d410a6 100644 (file)
  */
 struct mtk_vcodec_enc_pdata {
        bool uses_ext;
-       unsigned long min_bitrate;
-       unsigned long max_bitrate;
+       u64 min_bitrate;
+       u64 max_bitrate;
        const struct mtk_video_fmt *capture_formats;
        size_t num_capture_formats;
        const struct mtk_video_fmt *output_formats;
        size_t num_output_formats;
-       int core_id;
+       u8 core_id;
        bool uses_34bit;
 };
 
@@ -198,7 +198,7 @@ struct mtk_vcodec_enc_dev {
        const struct mtk_vcodec_enc_pdata *venc_pdata;
 
        struct mtk_vcodec_fw *fw_handler;
-       unsigned long id_counter;
+       u64 id_counter;
 
        /* encoder hardware mutex lock */
        struct mutex enc_mutex;