Memory leak: always call g_propagate_error
authorAlberto Mardegan <mardy@users.sourceforge.net>
Sun, 17 Apr 2011 08:18:09 +0000 (11:18 +0300)
committerZeeshan Ali (Khattak) <zeeshanak@gnome.org>
Sun, 17 Apr 2011 16:33:59 +0000 (19:33 +0300)
Even if the "dest" error is NULL, we must call g_propagate_error()
because it free's the "src" error that would otherwise be leaked.

libgssdp/gssdp-client.c

index c38ef28..02851c8 100644 (file)
@@ -191,9 +191,7 @@ gssdp_client_constructed (GObject *object)
 
  errors:
         if (!client->priv->request_socket || !client->priv->multicast_socket) {
-                if (client->priv->error) {
                         g_propagate_error (client->priv->error, error);
-                }
                 return;
         }