[NFC][IntrRefLDV] Improve the Value printing
authorDjordje Todorovic <djordje.todorovic@syrmia.com>
Wed, 28 Oct 2020 14:18:14 +0000 (07:18 -0700)
committerDjordje Todorovic <djtodoro@cisco.com>
Wed, 28 Oct 2020 14:39:08 +0000 (07:39 -0700)
Basically, this just improves the dump of the Value stored within a location.

If the defining instruction number is zero, it means it is "live-in".

Before the patch:

ESI --> bb 0 inst 0 loc ESI
After:

ESI --> Value{bb: 0, inst: live-in, loc: ESI}
This is an NFC.

Differential Revision: https://reviews.llvm.org/D90309

llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp

index e737e95..7d593ec 100644 (file)
@@ -343,9 +343,12 @@ public:
   bool operator!=(const ValueIDNum &Other) const { return !(*this == Other); }
 
   std::string asString(const std::string &mlocname) const {
-    return Twine("bb ")
-        .concat(Twine(BlockNo).concat(Twine(" inst ").concat(
-            Twine(InstNo).concat(Twine(" loc ").concat(Twine(mlocname))))))
+    return Twine("Value{bb: ")
+        .concat(Twine(BlockNo).concat(
+            Twine(", inst: ")
+                .concat((InstNo ? Twine(InstNo) : Twine("live-in"))
+                            .concat(Twine(", loc: ").concat(Twine(mlocname)))
+                            .concat(Twine("}")))))
         .str();
   }