staging: bcm2835-audio: replace printk(KERN_ERR...) with dev_err(...)
authorAishwarya Pant <aishpant@gmail.com>
Thu, 2 Mar 2017 18:58:16 +0000 (00:28 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 6 Mar 2017 13:12:31 +0000 (14:12 +0100)
Use dev_err(... in place of printk(KERN_ERR ...
Problem found by checkpatch

Signed-off-by: Aishwarya Pant <aishpant@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c

index 46814fd..659c3d1 100644 (file)
@@ -139,10 +139,8 @@ static int snd_bcm2835_ctl_put(struct snd_kcontrol *kcontrol,
                }
        }
 
-       if (changed) {
-               if (bcm2835_audio_set_ctls(chip))
-                       printk(KERN_ERR "Failed to set ALSA controls..\n");
-       }
+       if (changed && bcm2835_audio_set_ctls(chip))
+               dev_err(chip->card->dev, "Failed to set ALSA controls..\n");
 
 unlock:
        mutex_unlock(&chip->audio_mutex);