isci: Device access in the error path does not depend on IDEV_GONE.
authorJeff Skirvin <jeffrey.d.skirvin@intel.com>
Fri, 9 Mar 2012 06:41:55 +0000 (22:41 -0800)
committerDan Williams <dan.j.williams@intel.com>
Thu, 17 May 2012 21:33:39 +0000 (14:33 -0700)
Signed-off-by: Jeff Skirvin <jeffrey.d.skirvin@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/scsi/isci/task.c

index 29ce881..9d8720d 100644 (file)
@@ -427,7 +427,7 @@ int isci_task_lu_reset(struct domain_device *dev, u8 *lun)
        int ret;
 
        spin_lock_irqsave(&ihost->scic_lock, flags);
-       idev = isci_lookup_device(dev);
+       idev = isci_get_device(dev->lldd_dev);
        spin_unlock_irqrestore(&ihost->scic_lock, flags);
 
        dev_dbg(&ihost->pdev->dev,
@@ -507,7 +507,7 @@ int isci_task_abort_task(struct sas_task *task)
        if (!(task->task_state_flags & SAS_TASK_STATE_DONE) &&
            (task->task_state_flags & SAS_TASK_AT_INITIATOR) &&
            old_request)
-               idev = isci_lookup_device(task->dev);
+               idev = isci_get_device(task->dev->lldd_dev);
 
        spin_unlock(&task->task_state_lock);
        spin_unlock_irqrestore(&ihost->scic_lock, flags);
@@ -593,6 +593,9 @@ int isci_task_abort_task(struct sas_task *task)
                                            ISCI_ABORT_TASK_TIMEOUT_MS);
        }
 out:
+       dev_warn(&ihost->pdev->dev,
+                "%s: Done; dev = %p, task = %p , old_request == %p\n",
+                __func__, idev, task, old_request);
        isci_put_device(idev);
        return ret;
 }