RDMA/mlx5: Remove redundant destroy QP call
authorLeon Romanovsky <leonro@mellanox.com>
Mon, 27 Apr 2020 15:46:34 +0000 (18:46 +0300)
committerJason Gunthorpe <jgg@mellanox.com>
Thu, 30 Apr 2020 21:45:46 +0000 (18:45 -0300)
After major refactoring in create QP flow, it is no needed to call
to destroy QP in XRC_TGT flow.

Link: https://lore.kernel.org/r/20200427154636.381474-35-leon@kernel.org
Reviewed-by: Maor Gottlieb <maorg@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/mlx5/qp.c

index 9ca7421..d7983a9 100644 (file)
@@ -1887,7 +1887,6 @@ static int create_xrc_tgt_qp(struct mlx5_ib_dev *dev, struct mlx5_ib_qp *qp,
                             struct mlx5_create_qp_params *params)
 {
        struct ib_qp_init_attr *attr = params->attr;
-       struct ib_udata *udata = params->udata;
        u32 uidx = params->uidx;
        struct mlx5_ib_resources *devr = &dev->devr;
        int inlen = MLX5_ST_SZ_BYTES(create_qp_in);
@@ -1944,10 +1943,8 @@ static int create_xrc_tgt_qp(struct mlx5_ib_dev *dev, struct mlx5_ib_qp *qp,
        base = &qp->trans_qp.base;
        err = mlx5_core_create_qp(dev, &base->mqp, in, inlen);
        kvfree(in);
-       if (err) {
-               destroy_qp(dev, qp, base, udata);
+       if (err)
                return err;
-       }
 
        base->container_mibqp = qp;
        base->mqp.event = mlx5_ib_qp_event;