netfilter: nf_tables: Drop pointless memset when dumping rules
authorPhil Sutter <phil@nwl.cc>
Fri, 29 Sep 2023 19:19:19 +0000 (21:19 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 20 Nov 2023 10:59:00 +0000 (11:59 +0100)
[ Upstream commit 30fa41a0f6df4c85790cc6499ddc4a926a113bfa ]

None of the dump callbacks uses netlink_callback::args beyond the first
element, no need to zero the data.

Fixes: 96518518cc41 ("netfilter: add nftables")
Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/netfilter/nf_tables_api.c

index 29c6518..3bf428a 100644 (file)
@@ -3465,10 +3465,6 @@ static int __nf_tables_dump_rules(struct sk_buff *skb,
                        goto cont_skip;
                if (*idx < s_idx)
                        goto cont;
-               if (*idx > s_idx) {
-                       memset(&cb->args[1], 0,
-                                       sizeof(cb->args) - sizeof(cb->args[0]));
-               }
                if (prule)
                        handle = prule->handle;
                else