rsi: fix uninitialized descriptor pointer issue
authorPrameela Rani Garnepudi <prameela.j04cs@gmail.com>
Thu, 3 Aug 2017 14:26:39 +0000 (19:56 +0530)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 8 Aug 2017 11:45:26 +0000 (14:45 +0300)
This patch fixes the uninitialized descriptor pointer
issue in function rsi_send_internal_mgmt_frame().
Descriptor should point to start of the skb data.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 9a629fafe7d8 ("rsi: immediate wakeup bit and priority for TX command packets")
Signed-off-by: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
Signed-off-by: Amitkumar Karwar <amit.karwar@redpinesignals.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/rsi/rsi_91x_mgmt.c

index 1fba7bb..c488f4b 100644 (file)
@@ -274,6 +274,7 @@ static int rsi_send_internal_mgmt_frame(struct rsi_common *common,
                rsi_dbg(ERR_ZONE, "%s: Unable to allocate skb\n", __func__);
                return -ENOMEM;
        }
+       desc = (struct rsi_cmd_desc *)skb->data;
        desc->desc_dword0.len_qno |= cpu_to_le16(DESC_IMMEDIATE_WAKEUP);
        skb->priority = MGMT_SOFT_Q;
        tx_params = (struct skb_info *)&IEEE80211_SKB_CB(skb)->driver_data;