Remove unnecessary ACK wait when process input device event 59/139959/2
authorJi-hoon Lee <dalton.lee@samsung.com>
Fri, 21 Jul 2017 06:38:12 +0000 (15:38 +0900)
committerJi-hoon Lee <dalton.lee@samsung.com>
Fri, 21 Jul 2017 07:06:58 +0000 (16:06 +0900)
Since the current input device event delivery does not support
replying with return value mechanism, the ACK wait process
between the EcoreSocketPanelAgent and SCIM helper is useless
when processing input device events.

Change-Id: I7c352d9c9e88396e89f9f1fee65279f2212bb25e

ism/modules/panelagent/ecoresocket/ecore_socket_panel_agent_module.cpp
ism/src/scim_helper.cpp

index 540d587..77efe88 100644 (file)
@@ -1046,10 +1046,7 @@ private:
         trans.put_data(data, len);
         int cmd;
 
-        if (trans.write_to_socket(client_socket)
-            && trans.read_from_socket(client_socket)
-            && trans.get_command(cmd) && cmd == SCIM_TRANS_CMD_REPLY
-            && trans.get_data(result)) {
+        if (trans.write_to_socket(client_socket)) {
             SCIM_DEBUG_MAIN(1) << __func__ << " success\n";
             return true;
         }
index 3c21e72..c7bc452 100644 (file)
@@ -1402,10 +1402,6 @@ HelperAgent::handle_message (MessageItem *message)
             uint32 ret = 0;
             m_impl->signal_process_input_device_event(this,
                 subclass->get_type_ref(), *(subclass->get_data_ptr()), subclass->get_len_ref(), ret);
-            m_impl->send.clear();
-            m_impl->send.put_command(SCIM_TRANS_CMD_REPLY);
-            m_impl->send.put_data(ret);
-            m_impl->send.write_to_socket(m_impl->socket);
             break;
         }
         case SCIM_TRANS_CMD_SET_AUTOCAPITAL_TYPE:
@@ -2028,7 +2024,6 @@ HelperAgent::get_surrounding_text (const String &uuid, int maxlen_before, int ma
 void
 HelperAgent::get_surrounding_text (int maxlen_before, int maxlen_after, String &text, int &cursor)
 {
-
     if (!m_impl->socket_active.is_connected ())
         return;