remoteproc: don't allow modular build
authorChristoph Hellwig <hch@lst.de>
Fri, 30 Aug 2019 06:43:12 +0000 (08:43 +0200)
committerChristoph Hellwig <hch@lst.de>
Wed, 4 Sep 2019 09:13:19 +0000 (11:13 +0200)
Remoteproc started using dma_declare_coherent_memory recently, which is
a bad idea from drivers, and the maintainers agreed to fix that.  But
until that is fixed only allow building the driver built in so that we
can remove the dma_declare_coherent_memory export and prevent other
drivers from "accidentally" using it like remoteproc.  Note that the
driver would also leak the declared coherent memory on unload if it
actually was built as a module at the moment.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/remoteproc/Kconfig

index 28ed306..94afdde 100644 (file)
@@ -2,7 +2,7 @@
 menu "Remoteproc drivers"
 
 config REMOTEPROC
-       tristate "Support for Remote Processor subsystem"
+       bool "Support for Remote Processor subsystem"
        depends on HAS_DMA
        select CRC32
        select FW_LOADER