projects
/
platform
/
adaptation
/
renesas_rcar
/
renesas_kernel.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
cb4855b
)
staging: nvec: potential NULL dereference on error path
author
Dan Carpenter
<dan.carpenter@oracle.com>
Thu, 7 Nov 2013 11:25:32 +0000
(14:25 +0300)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Mon, 25 Nov 2013 17:14:29 +0000
(09:14 -0800)
We assume nvec->rx can be NULL earlier so I have added a check here as
well.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/nvec/nvec.c
patch
|
blob
|
history
diff --git
a/drivers/staging/nvec/nvec.c
b/drivers/staging/nvec/nvec.c
index
3066ee2
..
49ea76b
100644
(file)
--- a/
drivers/staging/nvec/nvec.c
+++ b/
drivers/staging/nvec/nvec.c
@@
-681,7
+681,8
@@
static irqreturn_t nvec_interrupt(int irq, void *dev)
dev_err(nvec->dev,
"RX buffer overflow on %p: "
"Trying to write byte %u of %u\n",
- nvec->rx, nvec->rx->pos, NVEC_MSG_SIZE);
+ nvec->rx, nvec->rx ? nvec->rx->pos : 0,
+ NVEC_MSG_SIZE);
break;
default:
nvec->state = 0;