scsi: fdomain: Fix error return code in fdomain_probe()
authorWei Li <liwei391@huawei.com>
Thu, 15 Jul 2021 03:26:25 +0000 (11:26 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 10 Aug 2021 03:30:25 +0000 (23:30 -0400)
If request_region() fails the return value is not set. Return -EBUSY on
error.

Link: https://lore.kernel.org/r/20210715032625.1395495-1-liwei391@huawei.com
Fixes: 8674a8aa2c39 ("scsi: fdomain: Add PCMCIA support")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Li <liwei391@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/pcmcia/fdomain_cs.c

index e42acf3..33df6a9 100644 (file)
@@ -45,8 +45,10 @@ static int fdomain_probe(struct pcmcia_device *link)
                goto fail_disable;
 
        if (!request_region(link->resource[0]->start, FDOMAIN_REGION_SIZE,
-                           "fdomain_cs"))
+                           "fdomain_cs")) {
+               ret = -EBUSY;
                goto fail_disable;
+       }
 
        sh = fdomain_create(link->resource[0]->start, link->irq, 7, &link->dev);
        if (!sh) {