mips: ath79: clock:- Unmap region obtained by of_iomap
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Mon, 2 Jan 2017 09:48:21 +0000 (15:18 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 8 Oct 2017 08:26:07 +0000 (10:26 +0200)
[ Upstream commit b3d91db3f71d5f70ea60d900425a3f96aeb3d065 ]

Free memory mapping, if ath79_clocks_init_dt_ng is not successful.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Fixes: 3bdf1071ba7d ("MIPS: ath79: update devicetree clock support for AR9132")
Cc: antonynpavlov@gmail.com
Cc: albeu@free.fr
Cc: hackpascal@gmail.com
Cc: sboyd@codeaurora.org
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/14915/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/mips/ath79/clock.c

index cc3a1e3..7e2bb12 100644 (file)
@@ -508,16 +508,19 @@ static void __init ath79_clocks_init_dt_ng(struct device_node *np)
                ar9330_clk_init(ref_clk, pll_base);
        else {
                pr_err("%s: could not find any appropriate clk_init()\n", dnfn);
-               goto err_clk;
+               goto err_iounmap;
        }
 
        if (of_clk_add_provider(np, of_clk_src_onecell_get, &clk_data)) {
                pr_err("%s: could not register clk provider\n", dnfn);
-               goto err_clk;
+               goto err_iounmap;
        }
 
        return;
 
+err_iounmap:
+       iounmap(pll_base);
+
 err_clk:
        clk_put(ref_clk);