[Title] If use -p all option, -skip option does not work.
authoryongsung1.kim <yongsung1.kim@samsung.com>
Fri, 2 Aug 2013 09:17:16 +0000 (18:17 +0900)
committeryongsung1.kim <yongsung1.kim@samsung.com>
Fri, 2 Aug 2013 09:17:16 +0000 (18:17 +0900)
[Desc.] -skip option works well when use -p all option.
[Issue] redmine #10136

Change-Id: I2107dcd7ab70b503ba18a8910f56b4cc5c6ecd85

InstallManager_java/src/org/tizen/installmanager/cli/CliInstall.java

index eb6b162..fd8f55a 100644 (file)
@@ -93,9 +93,11 @@ public class CliInstall {
                Registry.sdkWorkSpacePath = getSDKDataPath();
                Config.USER_CONFIG_HOME_PATH = getSDKDataPath();
                
+               PackageSet skipPackages = pm.getPackagesByNames(Options.skipPackages);
+               
                if (packageNames.contains("all")) {
                        if (checkAvailableSize(getAllPackages(), targetDir)) {
-                               return installPackages(getAllPackages(), targetDir);                            
+                               return installPackages(pm.diff(getAllPackages(), skipPackages), targetDir);                             
                        }
                } else if (!validateInstallPkgs(pm, packageNames)) {
                        return false;
@@ -107,8 +109,7 @@ public class CliInstall {
                List<String> installableMetaNames = getInstallableMetas(pm, packageNames);
                PackageSet installableMetas = pm.getPackagesByNames(installableMetaNames);
                PackageSet installablePackages = pm.getDependsPackagesFromRepository(installableMetas);
-               PackageSet skipPackages = pm.getPackagesByNames(Options.skipPackages);
-               
+
                if (!skipPackages.isEmpty()) {
                        Log.log("Installation skip packages : " + skipPackages);
                        installablePackages = pm.diff(installablePackages, skipPackages);