2008-10-10 Matthias Clasen <mclasen@redhat.com>
+ Bug 554557 – Patch to fix gcc warnings about missing format
+ specifiers
+
+ * glib/gmarkup.c:
+ * glib/gshell.c:
+ * glib/grel.c: Fix gcc warnings. Patch by Kjartan Maraas
+
+2008-10-10 Matthias Clasen <mclasen@redhat.com>
+
Bug 552861 – glib-2.0.m4 calls system(3) without storing its result
* m4macros/glib-2.0.m4: Cosmetic change to make -Werror happy.
+2008-10-10 Matthias Clasen <mclasen@redhat.com>
+
+ * gio/glocalfileinfo.c:
+ * gio/tests/live-g-file.c:
+ * gio/gsimpleasyncresult.c: Fix gcc warnings.
+
2008-10-09 Alexander Larsson <alexl@redhat.com>
* gunixinputstream.c (g_unix_input_stream_read):
{
if (value->type != G_FILE_ATTRIBUTE_TYPE_STRING)
{
- g_set_error (error, G_IO_ERROR, G_IO_ERROR_INVALID_ARGUMENT,
- _("Invalid attribute type (byte string expected)"));
+ g_set_error_literal (error, G_IO_ERROR, G_IO_ERROR_INVALID_ARGUMENT,
+ _("Invalid attribute type (byte string expected)"));
return FALSE;
}
if (val == NULL)
{
- g_set_error (error, G_IO_ERROR, G_IO_ERROR_INVALID_ARGUMENT,
- _("SELinux context must be non-NULL"));
+ g_set_error_literal (error, G_IO_ERROR, G_IO_ERROR_INVALID_ARGUMENT,
+ _("SELinux context must be non-NULL"));
return FALSE;
}
}
g_free (val_s);
} else {
- g_set_error (error, G_IO_ERROR, G_IO_ERROR_INVALID_ARGUMENT,
- _("SELinux is not enabled on this system"));
+ g_set_error_literal (error, G_IO_ERROR, G_IO_ERROR_INVALID_ARGUMENT,
+ _("SELinux is not enabled on this system"));
return FALSE;
}
#endif
g_simple_async_result_set_error (simple,
G_IO_ERROR,
G_IO_ERROR_CANCELLED,
+ "%s",
_("Operation was cancelled"));
else
data->func (simple,
if (! target_path)
{
g_print ("error: target path was not specified\n");
- g_print (g_option_context_get_help (context, TRUE, NULL));
+ g_print ("%s", g_option_context_get_help (context, TRUE, NULL));
return g_test_run ();
}
set_error (context,
error,
G_MARKUP_ERROR_BAD_UTF8,
+ "%s",
_("Invalid UTF-8 encoded text - overlong sequence"));
}
set_error (context,
error,
G_MARKUP_ERROR_BAD_UTF8,
+ "%s",
_("Invalid UTF-8 encoded text - not a start char"));
goto finished;
}
set_error (context,
error,
G_MARKUP_ERROR_PARSE,
+ "%s",
_("Document must begin with an element (e.g. <book>)"));
}
}
if (context->document_empty)
{
- set_error (context, error, G_MARKUP_ERROR_EMPTY,
+ set_error (context, error, G_MARKUP_ERROR_EMPTY, "%s",
_("Document was empty or contained only whitespace"));
return FALSE;
}
break;
case STATE_AFTER_OPEN_ANGLE:
- set_error (context, error, G_MARKUP_ERROR_PARSE,
+ set_error (context, error, G_MARKUP_ERROR_PARSE, "%s",
_("Document ended unexpectedly just after an open angle bracket '<'"));
break;
break;
case STATE_INSIDE_OPEN_TAG_NAME:
- set_error (context, error, G_MARKUP_ERROR_PARSE,
+ set_error (context, error, G_MARKUP_ERROR_PARSE, "%s",
_("Document ended unexpectedly inside an element name"));
break;
case STATE_INSIDE_ATTRIBUTE_NAME:
case STATE_AFTER_ATTRIBUTE_NAME:
- set_error (context, error, G_MARKUP_ERROR_PARSE,
+ set_error (context, error, G_MARKUP_ERROR_PARSE, "%s",
_("Document ended unexpectedly inside an attribute name"));
break;
case STATE_BETWEEN_ATTRIBUTES:
- set_error (context, error, G_MARKUP_ERROR_PARSE,
+ set_error (context, error, G_MARKUP_ERROR_PARSE, "%s",
_("Document ended unexpectedly inside an element-opening "
"tag."));
break;
case STATE_AFTER_ATTRIBUTE_EQUALS_SIGN:
- set_error (context, error, G_MARKUP_ERROR_PARSE,
+ set_error (context, error, G_MARKUP_ERROR_PARSE, "%s",
_("Document ended unexpectedly after the equals sign "
"following an attribute name; no attribute value"));
break;
case STATE_INSIDE_ATTRIBUTE_VALUE_SQ:
case STATE_INSIDE_ATTRIBUTE_VALUE_DQ:
- set_error (context, error, G_MARKUP_ERROR_PARSE,
+ set_error (context, error, G_MARKUP_ERROR_PARSE, "%s",
_("Document ended unexpectedly while inside an attribute "
"value"));
break;
break;
case STATE_INSIDE_PASSTHROUGH:
- set_error (context, error, G_MARKUP_ERROR_PARSE,
+ set_error (context, error, G_MARKUP_ERROR_PARSE, "%s",
_("Document ended unexpectedly inside a comment or "
"processing instruction"));
break;
case 45:
/* These errors should not happen as we are using an UTF8-enabled PCRE
* and we do not check if strings are valid */
- g_warning (*errmsg);
+ g_warning ("%s", *errmsg);
*errcode = G_REGEX_ERROR_COMPILE;
break;
default:
if (!support)
{
msg = N_("PCRE library is compiled without UTF8 support");
- g_critical (msg);
+ g_critical ("%s", msg);
g_set_error_literal (error, G_REGEX_ERROR, G_REGEX_ERROR_COMPILE, gettext (msg));
return NULL;
}
if (!support)
{
msg = N_("PCRE library is compiled without UTF8 properties support");
- g_critical (msg);
+ g_critical ("%s", msg);
g_set_error_literal (error, G_REGEX_ERROR, G_REGEX_ERROR_COMPILE, gettext (msg));
return NULL;
}
}
g_string_append (gstring, "]");
- g_log (G_LOG_DOMAIN, G_LOG_LEVEL_INFO, gstring->str);
+ g_log (G_LOG_DOMAIN, G_LOG_LEVEL_INFO, "%s", gstring->str);
g_string_free (gstring, TRUE);
}
if (!(*s == '"' || *s == '\''))
{
if (err)
- *err = g_error_new(G_SHELL_ERROR,
- G_SHELL_ERROR_BAD_QUOTING,
- _("Quoted text doesn't begin with a quotation mark"));
+ *err = g_error_new_literal (G_SHELL_ERROR,
+ G_SHELL_ERROR_BAD_QUOTING,
+ _("Quoted text doesn't begin with a quotation mark"));
*end = str;
return FALSE;
}
*dest = '\0';
if (err)
- *err = g_error_new(G_SHELL_ERROR,
- G_SHELL_ERROR_BAD_QUOTING,
- _("Unmatched quotation mark in command line or other shell-quoted text"));
+ *err = g_error_new_literal (G_SHELL_ERROR,
+ G_SHELL_ERROR_BAD_QUOTING,
+ _("Unmatched quotation mark in command line or other shell-quoted text"));
*end = s;
return FALSE;
}