io_uring: remove setting REQ_F_MUST_PUNT in rw
authorPavel Begunkov <asml.silence@gmail.com>
Sun, 21 Jun 2020 10:09:50 +0000 (13:09 +0300)
committerJens Axboe <axboe@kernel.dk>
Mon, 22 Jun 2020 02:46:03 +0000 (20:46 -0600)
io_{read,write}() {
...
copy_iov: // prep async
   if (!(flags & REQ_F_NOWAIT) && !file_can_poll(file))
flags |= REQ_F_MUST_PUNT;
}

REQ_F_MUST_PUNT there is pointless, because if it happens then
REQ_F_NOWAIT is known to be _not_ set, and the request will go
async path in __io_queue_sqe() anyway. file_can_poll() check
is also repeated in arm_poll*(), so don't need it.

Remove the mentioned assignment REQ_F_MUST_PUNT in preparation
for killing the flag.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c

index 5d1685e..13f72d2 100644 (file)
@@ -2920,10 +2920,6 @@ copy_iov:
                                                inline_vecs, &iter);
                        if (ret)
                                goto out_free;
-                       /* any defer here is final, must blocking retry */
-                       if (!(req->flags & REQ_F_NOWAIT) &&
-                           !file_can_poll(req->file))
-                               req->flags |= REQ_F_MUST_PUNT;
                        /* if we can retry, do so with the callbacks armed */
                        if (io_rw_should_retry(req)) {
                                ret2 = io_iter_do_read(req, &iter);
@@ -3057,10 +3053,6 @@ copy_iov:
                                                inline_vecs, &iter);
                        if (ret)
                                goto out_free;
-                       /* any defer here is final, must blocking retry */
-                       if (!(req->flags & REQ_F_NOWAIT) &&
-                           !file_can_poll(req->file))
-                               req->flags |= REQ_F_MUST_PUNT;
                        return -EAGAIN;
                }
        }