fix some coverity issues

Change-Id: If264b91431f878c571e4263c453aa9895b1cb866

diff --git a/src/lib/drm/drm-output.c b/src/lib/drm/drm-output.c
index dfcf3d5..78bfa3f 100644 (file)
--- a/src/lib/drm/drm-output.c
+++ b/src/lib/drm/drm-output.c
@@ -509,6 +509,7 @@ drm_output_set_cursor(drm_output_t *output)
                resource = pepper_buffer_get_resource(buffer);
 
                shm_buffer = wl_shm_buffer_get(resource);
+               PEPPER_CHECK(shm_buffer, return, "shm_buffer is NULL.\n");
                stride = wl_shm_buffer_get_stride(shm_buffer);
                data = wl_shm_buffer_get_data(shm_buffer);
 
@@ -564,6 +565,7 @@ drm_output_repaint(void *o, const pepper_list_t *plane_list)
                if (!output->front) {
                        ret = drmModeSetCrtc(output->drm->fd, output->crtc_id, output->back->id, 0, 0,
                                                                 &output->conn->id, 1, output->mode);
+                       PEPPER_CHECK(ret == 0, , "drmModeSetCrtc failed.\n");
                }
 
                ret = drmModePageFlip(output->drm->fd, output->crtc_id, output->back->id,

diff --git a/src/lib/drm/drm-plane.c b/src/lib/drm/drm-plane.c
index 855fc10..380c97b 100644 (file)
--- a/src/lib/drm/drm-plane.c
+++ b/src/lib/drm/drm-plane.c
@@ -38,7 +38,7 @@ drm_init_planes(pepper_drm_t *drm)
 
        for (i = 0; i < (int)res->count_planes; i++) {
                drm_plane_t *plane = calloc(1, sizeof(drm_plane_t));
-               PEPPER_CHECK(plane, continue, "calloc() failed.\n");
+               PEPPER_CHECK(plane, break, "calloc() failed.\n");
 
                plane->plane = drmModeGetPlane(drm->fd, res->planes[i]);
                if (!plane->plane) {

diff --git a/src/lib/tdm/tdm-output.c b/src/lib/tdm/tdm-output.c
index 737a5fb..6c86c3c 100644 (file)
--- a/src/lib/tdm/tdm-output.c
+++ b/src/lib/tdm/tdm-output.c
@@ -301,7 +301,10 @@ __tdm_output_plane_init(pepper_tdm_output_t *output)
                if (plane->caps & TDM_LAYER_CAPABILITY_PRIMARY) {
                        output->primary_plane = plane;
                }
-               tdm_layer_set_info(plane->layer, &info);
+
+               err = tdm_layer_set_info(plane->layer, &info);
+               PEPPER_CHECK(err == TDM_ERROR_NONE, goto error,
+                                        "tdm_layer_set_info failed err:%d\n", err);
        }
 
        if (!output->primary_plane) {