`str` must be valid UTF-8, which is not guaranteed for C++ strings.
Reviewed By: ftynse
Differential Revision: https://reviews.llvm.org/D147818
"data",
[](PyOpaqueAttribute &self) {
MlirStringRef stringRef = mlirOpaqueAttrGetData(self);
- return py::str(stringRef.data, stringRef.length);
+ return py::bytes(stringRef.data, stringRef.length);
},
- "Returns the data for the Opaqued attributes as a string");
+ "Returns the data for the Opaqued attributes as `bytes`");
}
};
return py::str(stringRef.data, stringRef.length);
},
"Returns the value of the string attribute");
+ c.def_property_readonly(
+ "value_bytes",
+ [](PyStringAttribute &self) {
+ MlirStringRef stringRef = mlirStringAttrGetValue(self);
+ return py::bytes(stringRef.data, stringRef.length);
+ },
+ "Returns the value of the string attribute as `bytes`");
}
};
oattr = OpaqueAttr(Attribute.parse("#pytest_dummy.dummyattr<>"))
# CHECK: oattr value: pytest_dummy
print("oattr value:", oattr.dialect_namespace)
- # CHECK: oattr value: dummyattr<>
+ # CHECK: oattr value: b'dummyattr<>'
print("oattr value:", oattr.data)
# Test factory methods.
sattr = StringAttr(Attribute.parse('"stringattr"'))
# CHECK: sattr value: stringattr
print("sattr value:", sattr.value)
+ # CHECK: sattr value: b'stringattr'
+ print("sattr value:", sattr.value_bytes)
# Test factory methods.
# CHECK: default_get: "foobar"
print(f"Attribute type {fattr.type}, value {fattr.value}")
# CHECK: Attribute value text
print(f"Attribute value {sattr.value}")
+ # CHECK: Attribute value b'text'
+ print(f"Attribute value {sattr.value_bytes}")
# We don't know in which order the attributes are stored.
# CHECK-DAG: NamedAttribute(dependent="text")