NFSD: Update the NFSv2 RENAME argument decoder to use struct xdr_stream
authorChuck Lever <chuck.lever@oracle.com>
Wed, 21 Oct 2020 16:35:41 +0000 (12:35 -0400)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 25 Jan 2021 14:36:26 +0000 (09:36 -0500)
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfsxdr.c

index 00a7db8..d4f4729 100644 (file)
@@ -344,15 +344,13 @@ nfssvc_decode_createargs(struct svc_rqst *rqstp, __be32 *p)
 int
 nfssvc_decode_renameargs(struct svc_rqst *rqstp, __be32 *p)
 {
+       struct xdr_stream *xdr = &rqstp->rq_arg_stream;
        struct nfsd_renameargs *args = rqstp->rq_argp;
 
-       if (!(p = decode_fh(p, &args->ffh))
-        || !(p = decode_filename(p, &args->fname, &args->flen))
-        || !(p = decode_fh(p, &args->tfh))
-        || !(p = decode_filename(p, &args->tname, &args->tlen)))
-               return 0;
-
-       return xdr_argsize_check(rqstp, p);
+       return svcxdr_decode_diropargs(xdr, &args->ffh,
+                                      &args->fname, &args->flen) &&
+               svcxdr_decode_diropargs(xdr, &args->tfh,
+                                       &args->tname, &args->tlen);
 }
 
 int