media: atomisp: ov2680: don't declare unused vars
authorMauro Carvalho Chehab <mchehab@s-opensource.com>
Mon, 16 Apr 2018 16:37:09 +0000 (12:37 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 3 Aug 2018 05:50:33 +0000 (07:50 +0200)
[ Upstream commit e5c0680fd2c44252868fe4062558925b5506b179 ]

drivers/staging/media/atomisp/i2c/atomisp-ov2680.c: In function ‘__ov2680_set_exposure’:
drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:400:10: warning: variable ‘hts’ set but not used [-Wunused-but-set-variable]
  u16 vts,hts;
          ^~~
drivers/staging/media/atomisp/i2c/atomisp-ov2680.c: In function ‘ov2680_detect’:
drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:1164:5: warning: variable ‘revision’ set but not used [-Wunused-but-set-variable]
  u8 revision;
     ^~~~~~~~

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/media/atomisp/i2c/ov2680.c

index 51b7d61..1795762 100644 (file)
@@ -396,12 +396,11 @@ static long __ov2680_set_exposure(struct v4l2_subdev *sd, int coarse_itg,
 {
        struct i2c_client *client = v4l2_get_subdevdata(sd);
        struct ov2680_device *dev = to_ov2680_sensor(sd);
-       u16 vts,hts;
+       u16 vts;
        int ret,exp_val;
 
        dev_dbg(&client->dev, "+++++++__ov2680_set_exposure coarse_itg %d, gain %d, digitgain %d++\n",coarse_itg, gain, digitgain);
 
-       hts = ov2680_res[dev->fmt_idx].pixels_per_line;
        vts = ov2680_res[dev->fmt_idx].lines_per_frame;
 
        /* group hold */
@@ -1190,7 +1189,8 @@ static int ov2680_detect(struct i2c_client *client)
                                        OV2680_SC_CMMN_SUB_ID, &high);
        revision = (u8) high & 0x0f;
 
-       dev_info(&client->dev, "sensor_revision id = 0x%x\n", id);
+       dev_info(&client->dev, "sensor_revision id = 0x%x, rev= %d\n",
+                id, revision);
 
        return 0;
 }