clk: at91: check pmc node status before registering syscore ops
authorClément Léger <clement.leger@bootlin.com>
Mon, 13 Sep 2021 08:26:33 +0000 (10:26 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Nov 2021 18:16:51 +0000 (19:16 +0100)
[ Upstream commit c405f5c15e9f6094f2fa1658e73e56f3058e2122 ]

Currently, at91 pmc driver always register the syscore_ops whatever
the status of the pmc node that has been found. When set as secure
and disabled, the pmc should not be accessed or this will generate
abort exceptions.
To avoid this, add a check on node availability before registering
the syscore operations.

Signed-off-by: Clément Léger <clement.leger@bootlin.com>
Link: https://lore.kernel.org/r/20210913082633.110168-1-clement.leger@bootlin.com
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Fixes: b3b02eac33ed ("clk: at91: Add sama5d2 suspend/resume")
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/clk/at91/pmc.c

index 20ee9dc..b40035b 100644 (file)
@@ -267,6 +267,11 @@ static int __init pmc_register_ops(void)
        if (!np)
                return -ENODEV;
 
+       if (!of_device_is_available(np)) {
+               of_node_put(np);
+               return -ENODEV;
+       }
+
        pmcreg = device_node_to_regmap(np);
        of_node_put(np);
        if (IS_ERR(pmcreg))