crash-stack: Fix handle leak

Fix vulnerablility caused by handle leak of file.

Change-Id: I037f547633f1d7f074eb63a5dcad2d9b921bfc1a
Signed-off-by: Sunmin Lee <sunm.lee@samsung.com>

diff --git a/src/crash-stack/crash-stack.c b/src/crash-stack/crash-stack.c
index 76ce25d..a9e5b2d 100644 (file)
--- a/src/crash-stack/crash-stack.c
+++ b/src/crash-stack/crash-stack.c
@@ -169,8 +169,10 @@ static char *try_symbol_from_elfs (Elf *core, Elf_Data *notes, uintptr_t address
 
             elf = elf_begin (fd, ELF_C_READ_MMAP, NULL);
 
-            if (NULL == elf)
+            if (NULL == elf) {
+              close(fd);
               return NULL;
+            }
 
             Elf_Scn *scn = NULL;
             *module_name = filenames;