sctp: remove redundant initialization of variable status

The variable status is being initialized with a value that is never read
and it is being updated later with a new value.  The initialization is
redundant and can be removed.  Also put the variable declarations into
reverse christmas tree order.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c
index 7ecaf7d..d19db22 100644 (file)
--- a/net/sctp/protocol.c
+++ b/net/sctp/protocol.c
@@ -1367,15 +1367,15 @@ static struct pernet_operations sctp_ctrlsock_ops = {
 /* Initialize the universe into something sensible.  */
 static __init int sctp_init(void)
 {
-       int i;
-       int status = -EINVAL;
-       unsigned long goal;
-       unsigned long limit;
        unsigned long nr_pages = totalram_pages();
+       unsigned long limit;
+       unsigned long goal;
+       int max_entry_order;
+       int num_entries;
        int max_share;
+       int status;
        int order;
-       int num_entries;
-       int max_entry_order;
+       int i;
 
        sock_skb_cb_check_size(sizeof(struct sctp_ulpevent));