perf intel-pt: Use FUP always when scanning for an IP
authorAdrian Hunter <adrian.hunter@intel.com>
Fri, 26 May 2017 08:17:08 +0000 (11:17 +0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 21 Jun 2017 14:35:46 +0000 (11:35 -0300)
The decoder will try to use branch packets to find an IP to start decoding
or to recover from errors. Currently the FUP packet is used only in the
case of an overflow, however there is no reason for that to be a special
case. So just use FUP always when scanning for an IP.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/1495786658-18063-8-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/intel-pt-decoder/intel-pt-decoder.c

index 72b9dc8..923c60e 100644 (file)
@@ -1882,14 +1882,10 @@ static int intel_pt_walk_to_ip(struct intel_pt_decoder *decoder)
                        break;
 
                case INTEL_PT_FUP:
-                       if (decoder->overflow) {
-                               if (intel_pt_have_ip(decoder))
-                                       intel_pt_set_ip(decoder);
-                               if (decoder->ip)
-                                       return 0;
-                       }
-                       if (decoder->packet.count && decoder->have_last_ip)
-                               intel_pt_set_last_ip(decoder);
+                       if (intel_pt_have_ip(decoder))
+                               intel_pt_set_ip(decoder);
+                       if (decoder->ip)
+                               return 0;
                        break;
 
                case INTEL_PT_MTC: