[Shell] Hide Shell types from being browsable (#5915)
authorShane Neuville <shane94@hotmail.com>
Mon, 15 Apr 2019 16:22:47 +0000 (10:22 -0600)
committerGitHub <noreply@github.com>
Mon, 15 Apr 2019 16:22:47 +0000 (10:22 -0600)
* set shell things to EditorBrowsable false

* - EditorBrowsable always

* delete tab content

Xamarin.Forms.Core/Shell/ShellContent.cs
Xamarin.Forms.Core/Shell/ShellItem.cs
Xamarin.Forms.Core/Shell/ShellSection.cs

index 843e24f..799f208 100644 (file)
@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
 using System.Collections.Specialized;
+using System.ComponentModel;
 
 #if NETSTANDARD1_0
 using System.Linq;
@@ -12,10 +13,6 @@ using Xamarin.Forms.Internals;
 
 namespace Xamarin.Forms
 {
-       public class TabContent : ShellContent
-       {
-       }
-
        [ContentProperty(nameof(Content))]
        public class ShellContent : BaseShellItem, IShellContentController
        {
index 955b2fc..a4cff83 100644 (file)
@@ -4,15 +4,18 @@ using System.Collections.ObjectModel;
 using System.Collections.Specialized;
 using System.Threading.Tasks;
 using Xamarin.Forms.Internals;
+using System.ComponentModel;
 
 namespace Xamarin.Forms
 {
+       [EditorBrowsable(EditorBrowsableState.Always)]
        public class FlyoutItem : ShellItem
        {
                public ShellSectionCollection Tabs => Items;
        }
 
        [ContentProperty(nameof(Items))]
+       [EditorBrowsable(EditorBrowsableState.Never)]
        public class ShellItem : ShellGroupItem, IShellItemController, IElementConfiguration<ShellItem>, IPropertyPropagationController
        {
                #region PropertyKeys
index 16ac997..6d46577 100644 (file)
@@ -6,15 +6,18 @@ using System.Diagnostics;
 using System.Linq;
 using System.Threading.Tasks;
 using Xamarin.Forms.Internals;
+using System.ComponentModel;
 
 namespace Xamarin.Forms
 {
+       [EditorBrowsable(EditorBrowsableState.Always)]
        public class Tab : ShellSection
        {
                public ShellContentCollection Content => Items;
        }
 
        [ContentProperty(nameof(Items))]
+       [EditorBrowsable(EditorBrowsableState.Never)]
        public class ShellSection : ShellGroupItem, IShellSectionController, IPropertyPropagationController
        {
                #region PropertyKeys