selftests/bpf: Use consistent build-id type for liburandom_read.so
authorArtem Savkov <asavkov@redhat.com>
Fri, 4 Nov 2022 09:40:16 +0000 (10:40 +0100)
committerAndrii Nakryiko <andrii@kernel.org>
Fri, 4 Nov 2022 22:56:32 +0000 (15:56 -0700)
lld produces "fast" style build-ids by default, which is inconsistent
with ld's "sha1" style. Explicitly specify build-id style to be "sha1"
when linking liburandom_read.so the same way it is already done for
urandom_read.

Signed-off-by: Artem Savkov <asavkov@redhat.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: KP Singh <kpsingh@kernel.org>
Link: https://lore.kernel.org/bpf/20221104094016.102049-1-asavkov@redhat.com
tools/testing/selftests/bpf/Makefile

index 79edef1..f3cd170 100644 (file)
@@ -182,14 +182,15 @@ endif
 $(OUTPUT)/liburandom_read.so: urandom_read_lib1.c urandom_read_lib2.c
        $(call msg,LIB,,$@)
        $(Q)$(CLANG) $(filter-out -static,$(CFLAGS) $(LDFLAGS)) $^ $(LDLIBS)   \
-                    -fuse-ld=$(LLD) -Wl,-znoseparate-code -fPIC -shared -o $@
+                    -fuse-ld=$(LLD) -Wl,-znoseparate-code -Wl,--build-id=sha1 \
+                    -fPIC -shared -o $@
 
 $(OUTPUT)/urandom_read: urandom_read.c urandom_read_aux.c $(OUTPUT)/liburandom_read.so
        $(call msg,BINARY,,$@)
        $(Q)$(CLANG) $(filter-out -static,$(CFLAGS) $(LDFLAGS)) $(filter %.c,$^) \
                     liburandom_read.so $(LDLIBS)                              \
-                    -fuse-ld=$(LLD) -Wl,-znoseparate-code                     \
-                    -Wl,-rpath=. -Wl,--build-id=sha1 -o $@
+                    -fuse-ld=$(LLD) -Wl,-znoseparate-code -Wl,--build-id=sha1 \
+                    -Wl,-rpath=. -o $@
 
 $(OUTPUT)/sign-file: ../../../../scripts/sign-file.c
        $(call msg,SIGN-FILE,,$@)